fix(card): only style figure if direct child of .card-body#4417
Open
pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Open
fix(card): only style figure if direct child of .card-body#4417pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Conversation
Contributor
Author
|
Another approach would be to not style |
Owner
|
What if we change the layer of diff to |
Contributor
Author
|
If the concern is only for I'm not sure if it is a good pattern to embed a card in a card, but something like this can happen: https://play.tailwindcss.com/nlNdv47z2d |
Owner
|
Right. Your solution is better for other situations as well 👍 |
Contributor
Author
|
We should decide on the parent-child relationship for |
Initial approach, to be refined after discussion: only style `figure` direct child of `.card`.
6770efb to
fad12ad
Compare
figure child of .card-body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial approach, to be refined after further discussion (only style
figuredirect child of.card):It looks like in card we apply styles to all
figureinside, but all examples are with the images as direct child ofcard(and it woul make sense).So I would say we should scope the style applied in card only to direct children of
card.https://play.tailwindcss.com/nZVaZs1bUq?file=css (has the example with the problem in #4416 and also all cards with image from docs)
What I am unsure about is the below, where my logic would say that
pshould also be only direct child ofcard-body(> :where(p)), but I am afraid that there are people that rely on the current behavior.close #4416