feat(collapse): improve collapse to only apply overflow clip when closed#4423
Open
pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Open
feat(collapse): improve collapse to only apply overflow clip when closed#4423pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
pdanpdan wants to merge 1 commit intosaadeghi:masterfrom
Conversation
- apply overflow clip instead of hidden (avoids focusing hidden elements in content) - it is only applied to content, not the whole collapse - it is only applied when closed Also fixed the case where the collapse-title is a label for the checkbox (in this case do not raise z-index for the checkbox example: https://play.tailwindcss.com/I2knEnK0ZO close saadeghi#4419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed the case where the collapse-title is a label for the checkbox (in this case do not raise z-index for the checkbox
example: https://play.tailwindcss.com/I2knEnK0ZO
close #4419