Skip to content

Use URI to find relative group path #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bogovicj wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use URI to find relative group path #16

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0a16e71
test: build ngff multiscales v0.4 metadata
bogovicj Apr 18, 2024
2e642a1
fix: toward fixing ngff multiscales paths on windows
bogovicj Apr 18, 2024
561a636
fix: use MetadataUtils.relative paths where applicable
bogovicj Apr 18, 2024
54cb8b4
test: ngff-multiscales better assert messages
bogovicj Apr 19, 2024
82d7ea2
fix: MetadataUtils relativePath for windows
bogovicj Apr 19, 2024
3f5afe0
style: formatting
bogovicj Apr 19, 2024
2bac7a8
doc: MetadataUtils relativePath
bogovicj Apr 19, 2024
e43f962
fix: relativePath regexp
bogovicj Apr 19, 2024
2da636a
perf: use URI.relativize for relative group path
bogovicj Apr 19, 2024
e1b5e4a
Merge branch 'main' into relative-group-path
bogovicj Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/org/janelia/saalfeldlab/n5/universe/metadata/MetadataUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.janelia.saalfeldlab.n5.universe.metadata;

import java.net.URI;
import java.net.URISyntaxException;
import java.nio.file.Path;
import java.nio.file.Paths;
Expand Down Expand Up @@ -205,10 +206,10 @@ public static String normalizeGroupPath(final String path) {
public static String relativePath(final String parent, final String child) {

try {
final String purl = new N5URI("?" + parent).normalizeGroupPath();
final String curl = new N5URI("?" + child).normalizeGroupPath();
return new N5URI("?" + curl.replaceFirst("^"+purl, "")).normalizeGroupPath();
} catch (final URISyntaxException e) {}
return new URI(N5URI.normalizeGroupPath(parent)).relativize(
new URI(N5URI.normalizeGroupPath(child)))
.toASCIIString();
} catch (URISyntaxException e) {}
return child;
}

Expand Down