Opening of OME Zarr v0.5 datasets due to inconsistency of axes ordering - #49
Closed
stefanhahmann wants to merge 1 commit into
Closed
Opening of OME Zarr v0.5 datasets due to inconsistency of axes ordering#49stefanhahmann wants to merge 1 commit into
stefanhahmann wants to merge 1 commit into
Conversation
* Add a new method reversedCopy() to MetadataUtils * Add corresponding unit test
Collaborator
|
This is now merged and released, thanks @stefanhahmann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug: saalfeldlab/n5-viewer#54
I am a bit unsure, if there are any side effects by only re-ordering the axes in the deseralization step, but not in serialization step. Perhaps it should happen there as well.
OME Zarr v0.5 Metadata deserialization update:
MultiscalesAdapter.deserializeto reverse the order of axes when constructingOmeNgffMultiScaleMetadata, ensuring axes are handled in the correct order.Array reversal utility:
reversedCopymethod toMetadataUtilsfor creating reversed copies of arrays.Testing:
MetadataUtilsTestwith unit tests forreversedCopy, covering string, integer, and empty arrays.