OME-Zarr metadata parsing fixes and refactor - #54
Merged
Conversation
* remove unused N5DatasetDiscoverer constructors * fix Ngff v0.3 parsing
the purpose of these methods is to more flexibly support backend specific N5Reader/Writers without needing to introduce new methods for each type. To that end, this also deprecates the various backend specific methods Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
ZARR storage previously referred to zarr 2. given the update to support zarr 3, ZARR3 was introduced. However, ZARR should still exists as a "generic zarr" format that prefers the newest zarr version. The behavior of ZARR is as follows For readers in order: - return a Zarr3 reader - else return a Zarr2 reader For Writers, in order of attempt: - if the location contains a zarr3 container, try to open a zarr3 writer - else if the location contains a zarr2 container, try to open a zarr2 writer - else if there is no existing zarr container, attempt to create a Zarr3 container. - if a Zarr3 container could not be created, create a zarr2 container. Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
…riter method. normalizeUri only for cache keys, not for creating the reader/writer Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
Signed-off-by: John Bogovic <bogovicj@janelia.hhmi.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and refactor (de)serialization of OME-Zarr metadata.
versionserialization for v0.5