Add N5Writer.writeRegion methods - #178
Merged
Merged
Conversation
NestedPosition is always constructed via NestedGrid factory methods. Added methods to determine the pixel coordinates corresponding to a NestedPosition. Cleaned up unused code and comments.
writeRegion() takes a DataBlockSupplier and a region in pixel coordinates that should be written. It decised which shards/blocks need to be touched and asks the DataBlockSupplier for the respective blocks. Currently only minimal parallelization (over shards) is implemented. This could be improved in the future, if called with a ForkJoinPool executor. Then we could further parallelize the production and encoding of DataBlocks.
This should be handled by a dedicated DatasetAccess method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeRegion()takes aDataBlockSupplierand a region in pixel coordinates that should be written. It decides which shards/blocks need to be touched and asks theDataBlockSupplierfor the respective blocks.Currently only minimal parallelization (over shards) is implemented. This could be improved in the future, if called with a
ForkJoinPoolexecutor. Then we could further parallelize the production and encoding of DataBlocks.