Converted dataset attributes - #191
Merged
Merged
Conversation
cmhulbert
added a commit
to saalfeldlab/n5-zarr
that referenced
this pull request
Jan 9, 2026
refactor[BREAKING]: remove constructor parameters for `mapAttributes`, `dimensionSeparator`, `mergeN5Attributes`. Map and Merge are no longer supported (they weren't really for ZarrV3 ever, but the constructors were inherited from ZarrV2). Dimension separator now has a getter/setter Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
cmhulbert
force-pushed
the
convertedDatasetAttributes
branch
from
January 12, 2026 16:56
3526907 to
d34f342
Compare
cmhulbert
marked this pull request as ready for review
January 12, 2026 19:37
cmhulbert
added a commit
to saalfeldlab/n5-zarr
that referenced
this pull request
Jan 12, 2026
refactor[BREAKING]: remove constructor parameters for `mapAttributes`, `dimensionSeparator`, `mergeN5Attributes`. Map and Merge are no longer supported (they weren't really for ZarrV3 ever, but the constructors were inherited from ZarrV2). Dimension separator now has a getter/setter Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.