Perf/io - #210
Merged
Merged
Conversation
…g via FileChannel. fix: ensure parent directories exist before writing file for Unsafe Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
…ust specify the TRUNCATE_EXISTING OpenOption. It is much faster Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
…ry (isFile -> throws, null -> creates) Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
…writes that also fail on closing the file. It's a bit more involved, since we need to flush the write operation, but the logic is the same as for read Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a few performance optimizations, mostly related to file IO. The largest performance gains were:
Files.copyfor Unsafe. It's much slower than writing via FileChannel.mkdircall is only necessary once per directory. It's cheaper on average to check before calling, instead of calling every time