refactor!: "block" → "chunk" and "shard" → "block" - #221
Merged
Conversation
* getBlockSize should correspond to readBlock / writeBlock * useful to have an analogue for readChunk / writeChunk
* that deletes blocks or chunks
* add clarifying javadoc * test blockSize == chunkSize when not sharded * fix block / chunk equivalence test and comments
* improve testReadChunkVsBlock
createDatasetAccess() can be private because we don't override it anywhere. (Maybe we did previously in n5-zarr?) getDatasetAccess() has to be protected for tests only. It is better for tests to use the canonical DatasetAccess instead of creating a separate one, as they did before using createDatasetAccess()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revisions of #216