new multi-SEM layer offset process#218
Merged
Merged
Conversation
…use the single best connected tile in each MFOV as a starting location
…sNearestToBox. Previously tiles with more overlap were not necessary considered to be nearer.
…0-ish pixel) differences between x offsets of different MFOVs in the z-1-to-2 test group. Original expectation was that differences between MFOVs in the same layer would almost always be small.
…s. Added --mopMaxAbsoluteMFOVTranslationDelta 150 to test case after learning from Thomas that the distance between 2 MFOVs can vary by up to 12 um = 150 pixels.
…rials work (e.g. between z 9 and 10). Identify largest MFOV translation delta x and y values and log them. Increase test case z range to be 1 to 30.
… so that all matches are included in ransac filter, validate offsetStackId at beginning of run
Collaborator
Author
|
I plan to merge this pull request into the newsolver branch in a few minutes so that it can be deployed to Janelia's render web services boxes. Once this is deployed, here is what remains to be done:
Most of the TODO items can be done with existing code. If anything needs to be added or fixed, I'll open another pull request for that. Feel free to add review comments to this pull request - I'll simply address them in a subsequent pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help us discuss changes, I plan to post multiple commits to this pull request as the new process is developed. Review comments are welcome at any time, but I'll add a comment indicating when I think I'm actually done in case you want to wait until then to start reviewing things.