Store PNGs to google cloud#222
Merged
Merged
Conversation
…d comment grammar issues flagged by editor
Collaborator
|
Looks great! I'll use this branch to add spark pipeline stuff that wraps what you've done here. |
…reused by future spark client
…aration for integration with future spark client
…a java client for each stack before distributing the rendering tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
RenderTilesClientto be able to store rendered tiles¹ to cloud storage².¹ Only PNGs are tested so far. The actual writing is done using
ImageIO.writeto write to aByteArrayOutputStream, which is subsequently uploaded. Every format that is supported by that workflow should work, but the parameters--convertToGrayand--qualityare ignored right now.² Only GCS is supported so far. For AWS, the changes to GCS shouldn't be too dramatic (since the actual object access is implemented using N5's
KeyValueAccess), but I haven't spent the time figuring out authentication details.Further caveats:
KeyValueAccessinterface does not allow for fine-grained control over the upload. This results in all images being tagged with typeapplication/octet-stream. To preview the images directly in GCS, one has to manually set the type toimage/png.I've tested that
Let me know if that's what you intended, @trautmane!