feat: store location coordinates in createRequest API payload instead…#1596
Open
rudra-sai-nag-aleti wants to merge 4 commits into
Open
feat: store location coordinates in createRequest API payload instead…#1596rudra-sai-nag-aleti wants to merge 4 commits into
rudra-sai-nag-aleti wants to merge 4 commits into
Conversation
… of address string
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
succeeds, stores
{ latitude, longitude }alongside the display addresssuggestion object and extract coordinates (
lat,lon) from OpenStreetMap response'{ latitude, longitude }' when coordinates are available, falls back to
address string if not
Behavior
Tests
to pass full suggestion object with coordinates
updated existing location test
when geolocation succeeds