feat: Customizable toolbar button size#1182
Open
QubaB wants to merge 7 commits intosaber-notes:mainfrom
Open
Conversation
ToolbarSize extended by ToolbarSizeGet to enable getting different size parameters directly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 37.49% 37.56% +0.06%
==========================================
Files 108 108
Lines 8564 8668 +104
==========================================
+ Hits 3211 3256 +45
- Misses 5353 5412 +59 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I probably did not choosed the best way. If you @adil192 tell me how to do it better, I rewrite code. I would like to have this option. Now my toolbar takes up two lines. |
adil192
requested changes
May 10, 2024
addes strings.i18n.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented 3 different sizes of toolbar buttons to allow user to choose smaller buttons if toolbar takes too big area of screen.
Closes #1146
also partialy closes #1177 (here probably the possibility to hide toolbar when typing text will be better solution - for example long press on text toolbar button)