feat: background line thickness settings added#1192
feat: background line thickness settings added#1192adil192 merged 2 commits intosaber-notes:mainfrom
Conversation
ed87823 to
d3dbac9
Compare
adil192
left a comment
There was a problem hiding this comment.
This is cool, can you just refactor lineWeight to lineThickness. Atm it looks too similar to lineHeight!
834e687 to
4951224
Compare
Sure. I have just refactored it into lineThickness but pipeline seems to be failing due to late initialization in 1 test. I have also added default value for the preference but not sure why its throwing error. Can you please let me know how to fix this? |
4951224 to
5cb0cd2
Compare
5cb0cd2 to
4c7eaff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
- Coverage 47.22% 47.15% -0.07%
==========================================
Files 114 114
Lines 8966 9002 +36
==========================================
+ Hits 4234 4245 +11
- Misses 4732 4757 +25 ☔ View full report in Codecov by Sentry. |
Oof yeah that was a tricky issue. |
Adds settings to control the thickness of background lines.