feat: Added select/deselect all notes button#1377
Open
Edgiest05 wants to merge 2 commits intosaber-notes:mainfrom
Open
feat: Added select/deselect all notes button#1377Edgiest05 wants to merge 2 commits intosaber-notes:mainfrom
Edgiest05 wants to merge 2 commits intosaber-notes:mainfrom
Conversation
Edgiest05
changed the title
Edgiest05
changed the title
Author
|
Same functionality is now available also in each directory of the browse page |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 46.09% 45.92% -0.17%
==========================================
Files 117 118 +1
Lines 8683 8716 +33
==========================================
+ Hits 4002 4003 +1
- Misses 4681 4713 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Edgiest05
force-pushed
the
feat-select-all
branch
from
620a0dc to
56797dd
Compare
Author
|
Resolved merge conflicts and updated |
Edgiest05
force-pushed
the
feat-select-all
branch
from
56797dd to
020b8af
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
020b8af to
99080d2
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
99080d2 to
b8aa4b7
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
b8aa4b7 to
8f4eb6e
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
8f4eb6e to
1a76d19
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
1a76d19 to
c8d9b91
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
c8d9b91 to
dbc6c69
Compare
Edgiest05
force-pushed
the
feat-select-all
branch
from
c4fc0f3 to
163af17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced button in recent page footer that allows for selection of all notes
When less than all files are selected
When all files have already been selected, behaviour changes to unselect all
While implementing this I had to address that newer version of the
saver_gallerydependency would not compile.Furthermore
preview_cardmakes use of a different variableexpandedwhen it actually should never differ from thewidget.selectedone (or else some selection changes do not reflect in the UI). I've kept it for consistency's sake.