Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1408 +/- ##
==========================================
- Coverage 46.09% 45.67% -0.42%
==========================================
Files 117 118 +1
Lines 8683 8794 +111
==========================================
+ Hits 4002 4017 +15
- Misses 4681 4777 +96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
Edgiest05
force-pushed
the
feat-sort-notes
branch
from
44e7513 to
fcadf75
Compare
Edgiest05
force-pushed
the
feat-sort-notes
branch
from
89f1ff6 to
0da881d
Compare
Contributor
|
Thank you for Your code, I merged it to my personal Saber. |
Edgiest05
force-pushed
the
feat-sort-notes
branch
from
0da881d to
d92e56c
Compare
Edgiest05
force-pushed
the
feat-sort-notes
branch
2 times, most recently
from
2a2b510 to
8c45153
Compare
Contributor
|
I like to sort folders by Name and files by date. Can this be implemented? |
Edgiest05
force-pushed
the
feat-sort-notes
branch
from
8c45153 to
1eb3367
Compare
Edgiest05
changed the title
Author
|
@QubaB it is possible to implement and it is quite easy to do so given that I already handle files and directories separately when sorting, unfortunately I personally don't need this level of fine tuning and I probably won't be working on that |
Contributor
|
OK, I will customize it to my needs. Thank you for the very nice improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a button
SortButtonlocated at the top-right of the UI in recent and browse pages (near the syncing one):When pressed it shows a dropdown for a predetermined selection, provided in the static class
SortNotes.Such selection is preserved as a preference and is kept on app restart.
Sdk version change is not related to my own implementation, but instead is a workaround to compilation errors that made it impossible to test on android emulator.