Add box selection tool#1718
Open
Donut-Muffin wants to merge 5 commits intosaber-notes:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 51.64% 52.00% +0.35%
==========================================
Files 131 134 +3
Lines 9376 9469 +93
==========================================
+ Hits 4842 4924 +82
- Misses 4534 4545 +11 ☔ View full report in Codecov by Sentry. |
Author
|
It appears like a lot of code has been added/removed but a significant portion is refactors since I renamed the Select tool to SelectLasso |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was only one lasso selection tool which users would have to drag around object to make selections.
This pull request adds a box selection tool that allows users to make rectangular selections around objects, rather than drawing around them.
Test cases have been implemented (based on the original lasso selection tests). The lasso selection tool has been refactored for clarity.
Sorry if the project structure needs improvement. This is my first time using Flutter and Dart.
Addresses issue #1675
box_select_demo.mp4