Skip to content

feat: creates user with private key and adds ERC-1271 wallet mock #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 6, 2025
Merged

feat: creates user with private key and adds ERC-1271 wallet mock #31

merged 5 commits into from
Jun 6, 2025

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Jun 3, 2025 •
edited
Loading

This PR is a pre-requisite of the following PRs:

Changelog

  1. Adds createUserAndKey helper function to return user and associated privateKey
  2. Adds mock wallet that implement isValidSignature function as required by EIP-1271
  3. Imports using relative path in source code

@smol-ninja smol-ninja force-pushed the feat/makeAddrAndKey branch 2 times, most recently from 79c9a92 to 004cbc2 Compare June 3, 2025 12:44
@smol-ninja
ci: revert lint ci
4bf6769 
build: fix script name
@smol-ninja smol-ninja force-pushed the feat/makeAddrAndKey branch from 004cbc2 to 4bf6769 Compare June 3, 2025 12:46
@smol-ninja smol-ninja changed the title feat: generates user and returns it with private key feat: creates user with private key and adds ERC-1271 wallet mocks Jun 3, 2025
@smol-ninja smol-ninja force-pushed the feat/makeAddrAndKey branch from 3ab2e3a to efd8acf Compare June 3, 2025 15:40
@smol-ninja smol-ninja changed the title feat: creates user with private key and adds ERC-1271 wallet mocks feat: creates user with private key and adds ERC-1271 wallet mock Jun 3, 2025
@smol-ninja smol-ninja mentioned this pull request Jun 3, 2025
Open
Copilot

This comment was marked as resolved.

Sign in to view

@smol-ninja
Copy link
Member Author

Can we merge this PR @andreivladbrg? Its a small change and will fix lint issue in your PR.

andreivladbrg
andreivladbrg approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, lets merge it

@andreivladbrg andreivladbrg merged commit dc59988 into main Jun 6, 2025
6 checks passed
@andreivladbrg andreivladbrg deleted the feat/makeAddrAndKey branch June 6, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @andreivladbrg