Fixed issue with multiple invites being send out with a comma in the recipient name/address#1542
Open
wlamers wants to merge 1 commit intosabre-io:masterfrom
Open
Fixed issue with multiple invites being send out with a comma in the recipient name/address#1542wlamers wants to merge 1 commit intosabre-io:masterfrom
wlamers wants to merge 1 commit intosabre-io:masterfrom
Conversation
…en there is a ',' in the recipient name/emailaddress'
DeepDiver1975
requested changes
Sep 5, 2024
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
we require some unit tests on this change. please add - thx
Contributor
|
@wlamers are you able to add unit tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using for example Thunderbird to create an invite an adding Attendees that have a comma in their name in the addressbook (of from collected emailaddresses in received emails) like e.g.:
"test, test test@test.com"
multiple RCPT TO: commands are send over SMTP, potentially causing issues with the mail server (postfix/dovecot). In our case the mail server want to send the invite to both the user "test" as the email "test@test.com". User "test" does not exist, causing the invite to end up in the 'catch-all' email account.
By extracting the emailadress using a regular expression the issue is resolved.