feat(carddav): allow pushing down filtering of reports #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
7 tasks
|
@phil-davis do you see any concerns with the approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
addressbook-querycurrently loads the full address book to filter in memory. Depending on the implementation it should be possible to push some of the filtering down to the implementation, e.g. to filter on a DB level first. This improves memory footprint and performance drastically.I'm opening this as proof of concept and hope to get some input on the approach and whether this would be accepted.
The same mechanism exists for caldav, where I took inspiration from. For BC I chose to not add a new method to the carddav backend interface.
nextcloud/server#55669 shows what it will look like in an implementation.