Add beforePropertyResolution event#1600
Open
salmart-dev wants to merge 4 commits intosabre-io:masterfrom
Open
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
addBeforePropFindEvent
branch
from
d9dfec8 to
3807e63
Compare
salmart-dev
changed the title
beforePropertyResolution event
salmart-dev
force-pushed
the
addBeforePropFindEvent
branch
2 times, most recently
from
2fa6b48 to
08c3404
Compare
This allows interested plugins to filter and slice the list of items for which properties are discovered, thus allowing the implementation of pagination logic that actually discovers properties for a small set of nodes at a time. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
addBeforePropFindEvent
branch
from
08c3404 to
314fded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
beforePropertyResolutionevent, to allow Plugins to slice and filter the paths for which properties are loaded during an HTTP PROPFIND request, in a similar manner as done for thebeforeMultiStatusevent.Use-case
This allows the implementation of a more efficient pagination, than what is currently possible by the use of
beforeMultiStatus. The current mechanism scans the whole tree under a path (according to the depth parameter) and loads properties for the nodes found, resulting in a slow initial request and requiring storing the rendered XML into a cache.It should be possible to "discover" the nodes for a PROPFIND request, store the list for paging, slice the list of propfinds and have Sabre return the properties for those nodes only.