Remove useless ResponseMock, fix obvious code issues#1615
Open
alecpl wants to merge 2 commits intosabre-io:masterfrom
Open
Remove useless ResponseMock, fix obvious code issues#1615alecpl wants to merge 2 commits intosabre-io:masterfrom
alecpl wants to merge 2 commits intosabre-io:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
============================================
+ Coverage 97.24% 97.25% +0.01%
- Complexity 2836 2842 +6
============================================
Files 175 175
Lines 8852 8862 +10
============================================
+ Hits 8608 8619 +11
+ Misses 244 243 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
FYI, we already have a breaking change in master, but this PR itself is not a breaking change. I hope this makes it easier to accept. |
CarlSchwan
approved these changes
Dec 19, 2025
Contributor
Author
|
@phil-davis @DeepDiver1975 what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen the direction to v5 and that it kinda stalled. So, I thought maybe I could help a bit, using more incremental approach instead of one big change (which I saw in the sabre-io/vobject repo).
So, I run phpstan with level=2 for now. It revealed a lot of obvious code mistakes. A lot of errors were also related to use of
ResponseMockclass, so I decided to get rid of it. I think it's better without it.If this approach is gonna be accepted I may spend some more time in this direction.
I did not include a change to phpstan.neon file for now, as it still throws a lot of errors.