PDOBasicAuth: compare email usernames case-insensitively#1629
Open
fujijin wants to merge 1 commit intosabre-io:masterfrom
Open
PDOBasicAuth: compare email usernames case-insensitively#1629fujijin wants to merge 1 commit intosabre-io:masterfrom
fujijin wants to merge 1 commit intosabre-io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1250
What changed
PDOBasicAuth::validateUserPass, keep exact lookup first.contains @), perform fallback lookup usinglower(uuidColumn) = lower(?).Why
Email addresses are generally treated case-insensitively in authentication flows.
This keeps existing semantics for non-email usernames while fixing email login mismatch caused by case differences.
Validation
php -l lib/DAV/Auth/Backend/PDOBasicAuth.phpphp -l tests/Sabre/DAV/Auth/Backend/AbstractPDOBasicAuthTestCase.php