Add some type annotations#1661
Merged
phil-davis merged 3 commits intoJul 11, 2026
Merged
Conversation
CarlSchwan
force-pushed
the
carl/add-type-annotations
branch
2 times, most recently
from
ad15c75 to
a251a76
Compare
CarlSchwan
force-pushed
the
carl/add-type-annotations
branch
2 times, most recently
from
3f619a9 to
d501a0e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1661 +/- ##
=========================================
Coverage 97.21% 97.22%
Complexity 2845 2845
=========================================
Files 175 175
Lines 8884 8885 +1
=========================================
+ Hits 8637 8638 +1
Misses 247 247 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ChristophWurst
left a comment
ChristophWurst
left a comment
Contributor
There was a problem hiding this comment.
Looks good
Reference args formatting could be split into a separate CS clean-up IMO
For now, these are 'safe' type hints. So more precise doc comments, returns type in class which are not supposed to be extended and parameters types in interfaces. Signed-off-by: Carl Schwan <carlschwan@kde.org>
This is backward compatible for all the classes that are supposed to be extended. Signed-off-by: Carl Schwan <carlschwan@kde.org>
phil-davis
force-pushed
the
carl/add-type-annotations
branch
from
d501a0e to
961c253
Compare
Mostly it has removed the space between the ampersand and the parameter name in pass-by-reference parameters.
phil-davis
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been sitting in a local stash for a while