chore: adjust code for cs-fixer no-useless-else#144
Merged
phil-davis merged 1 commit intosabre-io:masterfrom Mar 24, 2026
Merged
chore: adjust code for cs-fixer no-useless-else#144phil-davis merged 1 commit intosabre-io:masterfrom
phil-davis merged 1 commit intosabre-io:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
=========================================
Coverage 99.18% 99.18%
Complexity 111 111
=========================================
Files 7 7
Lines 370 370
=========================================
Hits 367 367
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The uncovered line is in Promise wait(), the very bottom line that throws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-cs-fixer 3.93 (among many other things) added a fixer for
no-useless-elsePHP-CS-Fixer/PHP-CS-Fixer#9340
Let php-cs-fixer get rid of these useless
elseblocks.No change to behaviour, so no need to release.