PHPstan level 2#498
Open
JeroenVanOort wants to merge 9 commits intosabre-io:masterfrom
webparking:phpstan-level-2
Open
PHPstan level 2#498JeroenVanOort wants to merge 9 commits intosabre-io:masterfrom webparking:phpstan-level-2
JeroenVanOort wants to merge 9 commits intosabre-io:masterfrom
webparking:phpstan-level-2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
============================================
+ Coverage 98.33% 98.68% +0.35%
- Complexity 1757 1760 +3
============================================
Files 67 66 -1
Lines 4328 4272 -56
============================================
- Hits 4256 4216 -40
+ Misses 72 56 -16
Continue to review full report at Codecov.
|
staabm
reviewed
Feb 2, 2020
Contributor
|
@JeroenVanOort I merged PR #500 that "standardizes" more CI stuff. |
Contributor
|
@JeroenVanOort this has been sitting for a while and now has conflicts. Are you able to rebase and resolve them again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no other way to make this happen than to make a custom PHPStan extension.