validate repair component should not deduplicate properties when properties must appear exactly once#615
Open
cedtaz wants to merge 1 commit intosabre-io:masterfrom
Open
validate repair component should not deduplicate properties when properties must appear exactly once#615cedtaz wants to merge 1 commit intosabre-io:masterfrom
cedtaz wants to merge 1 commit intosabre-io:masterfrom
Conversation
…erties must appear exactly once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate function with repair mode add automatically a property when the property must appear exactly once... like UID in VEVENT or VCARD.
A VCARD like this (with 2 UID for example) :
After a validate in repair mode, this VCARD looks like :
This can be very problematic. The test is not strict enough :
1 !== $propertyCounters[$propName]So we need to remove the old parameters when the number of properties is greater than 1. In fact, UID is a property which must appear exactly once.
Thanks.