Check for string-type parameter VALUE#636
Open
martijnvankekem wants to merge 1 commit intosabre-io:masterfrom
Open
Check for string-type parameter VALUE#636martijnvankekem wants to merge 1 commit intosabre-io:masterfrom
martijnvankekem wants to merge 1 commit intosabre-io:masterfrom
Conversation
Member
|
please add a test case |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
=========================================
Coverage 98.76% 98.76%
- Complexity 1866 1867 +1
=========================================
Files 71 71
Lines 5325 5325
=========================================
Hits 5259 5259
Misses 66 66 ☔ View full report in Codecov by Sentry. |
Contributor
|
@martijnvankekem your PR comes directly from the Please let us know the details of an example iCal structure - what does it pass in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #635