Test case for different sequences in base event and exception event#715
Open
gharlan wants to merge 1 commit intosabre-io:masterfrom
Open
Test case for different sequences in base event and exception event#715gharlan wants to merge 1 commit intosabre-io:masterfrom
gharlan wants to merge 1 commit intosabre-io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence in exception events can be different to the sequence of the base event. But the ITip broker always replies with the base sequence number, even for replies to exception events.
The pull requests shows the bug.
From iCalender RFC:
https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.7.4
Google Calendar uses different sequence numbers for exception events.
Example: Base event has sequence 2. When creating a new exception event, it gets the sequence number 3, but the base event keeps number 2.
Now when responding to the exception event via VObject iTip broker, the response contains the wrong sequence number 2, so the response is ignored by Google calender.