Open
Conversation
Eval does not need the labels collection. The label names already on the item are sufficient
the default Scanner mode includes floats and .Scan() was getting 3p (test example) and fails to make an actual floating point number out of it excluding scanner.ScanFloat avoids that possibility
Author
|
This PR was really just preparing for what I wanted to do, which was more fully implement the filter language. I have done the further work, you can see it here: How should I proceed, should I put those in this PR? I know it is a lot of change :-/ Happy to rework things here and there, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
ref #210