add: JSON tags to all exported struct fields in wrapper packages#44
Merged
Conversation
Signed-off-by: Kazumichi Yamamoto <yamamoto.febc@gmail.com>
tokuhirom
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
どのIssueを閉じますか？
issueなし
このPRはどういう変更を行いますか？
apis/下の全ラッパーパッケージで定義されている export 構造体に、JSON タグを追加しました。apis/version:ExposedPort,EnvironmentVariable,CreateParams,VersionDetailapis/application:ApplicationDetail,Placementapis/cluster:CreateParams,UpdateParams,ClusterDetailapis/certificate:CreateParams,UpdateParamsapis/loadbalancer:LoadBalancerInterface,NodeInterface,NodeInterfaceAddress,CreateParams,LoadBalancerDetail,LoadBalancerNodeDetailapis/autoscalinggroup:NodeInterface,CreateParams,AutoScalingGroupDetailapis/workernode:WorkerNodeDetail,WorkerNodeNetworkInterfaceタグ名は ogen 生成の
v1型と同じ camelCase で統一しています。ポインタ型・スライス型も含めて
omitemptyは付けていません。これにより、ラッパー型を直接 JSON marshal/unmarshal する際にフィールド名が PascalCase になる問題が解消されます。
ドキュメントの変更は必要ですか？
不要