Conversation
tusharojha
left a comment
tusharojha
left a comment
There was a problem hiding this comment.
Please check the added comments.
contracts/SadaivBackup.sol
Outdated
| } | ||
|
|
||
| mapping(uint256 => Repository) public userRepos; //repoId => repo | ||
| mapping(uint256 => mapping(string => Build)) public repoBuilds; //repoId => commitHash => build |
There was a problem hiding this comment.
RepoId -> commitHash -> build
is good but multiple branches can commit with same hash.
Repo
Commit Hash: 3x323
Branch A
now I use git pick this commit to new branch B and push
that will become
Commit Hash: 3x323
Branch B
There was a problem hiding this comment.
so what do you suggest can be the identifier for the commit?
There was a problem hiding this comment.
I think it should be simply: repoid -> branch -> commitHash -> build
I know this is quite nested.
or maybe something like you hash branch + commitHash and use it as id.
contracts/SadaivId.sol
Outdated
| uint256 _sadaivId = SCWAddressToSadaivId[signer]; | ||
| contributorData[_sadaivId] = cid; |
There was a problem hiding this comment.
Handle check if the profile doesn't exist?
If some random address try to update, _sadaivId would be zero. so pls add this check and write test for it.
…into new-features
2 participants
No description provided.