Add locale for en and cn#51
Open
jojowhoooo wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @sadmann7 on Vercel. @sadmann7 first needs to authorize it. |
Owner
|
thanks a lot, will merge soon |
Contributor
Author
|
Found an issue where, when the user is not logged in, switching languages in url will result in too many redirection prompts. too many redirection prompts details as follows: so i stop redirect in afterAuth. it works. if (!auth.userId) {
// If user tries to access a private route without being authenticated,
// redirect them to the sign in page
return
// url.pathname = "/signin"
// return NextResponse.redirect(url)
} |
Owner
|
I was looking over it. I requires an additional local folder. Can it be done without any additional folder? |
Contributor
Author
You mean folder named as [locale]? or some else, can you list them out? |
MaRokas2005
suggested changes
Aug 20, 2023
| export const dynamic = "force-dynamic" | ||
|
|
||
| export default async function IndexPage() { | ||
| export default async function IndexPage({params: {locale}}) { |
Contributor
There was a problem hiding this comment.
locale is string type{params: {locale: string}}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried two solutions, next-intl and i18next, and ultimately chose next-intl.
The compatibility between i18next and Clerk was not ideal, and it also enforced explicitly displaying the locale information in the URL, which is a bad user experience.
While next-intl is currently being used as a temporary workaround for static rendering pages, as the next.js default solution, it is expected to improve over time.
notes: It is supposed that adding language switch buttons on the header or footer in the future, as well as complete all i18n fields. I can participate in supplementing and reviewing the Chinese part. Thanks to the author for providing such a great learning project.
Reference: