Skip to content

Conversation

gjeanmart
Copy link
Collaborator

What it solves

Resolves #COR-28

Tenderly simulation with guard enabled accounts - Tx builder
We want the same behavior than for #OCX-48
It fails on the transaction builder because it is not part of the monorepo. More information are available on the 2nd Slack link.

How this PR fixes it

This PR introduces an additional state override for the Guard slot during simulation, ensuring that transactions can be simulated even without the required co-signature/approval.

How to test it

  1. Use a Safe with a Co-Signer Guard.
  2. Craft a transaction in the Tx Builder.
  3. Run a Tenderly simulation.
  • Before: Simulation failed due to missing co-signature/approval.
  • After: Simulation runs successfully without needing the co-signature/approval.

Screenshots

Before
image

After
image

Notes

  • ⚠️ A upgraded Hardhat from 2.12.6 to 2.19.0 to solve Node.js compatibility issue for versions > 18.

Implemented additional state override mechanism to disable cosigner
guard protection during simulation execution, preventing simulation
failures when guards are active.
@gjeanmart gjeanmart requested a review from dasanra September 25, 2025 15:41
@gjeanmart gjeanmart self-assigned this Sep 25, 2025
@gjeanmart gjeanmart added the Feature 👑 New feature or request label Sep 25, 2025
@github-actions
Copy link

Copy link
Collaborator

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gjeanmart gjeanmart changed the title [Transaction builder] [FEAT] [COR-28] Override state to pass simulation when Guard enabled feat: Transaction-Builder - Override state to pass simulation when Guard enabled [COR-28] Sep 25, 2025
@gjeanmart gjeanmart merged commit b823488 into development Sep 26, 2025
6 of 8 checks passed
@gjeanmart gjeanmart deleted the fix/COR-28/tenderly-simulation-with-guard-enabled-accounts-tx-builder branch September 26, 2025 06:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature 👑 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants