Fix CI #1128
Merged
Fix CI #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things happened at the same time: - A deployment was merged that was not correctly formatted - `prettier -c .` was added to the build step Since we `build` on `prepublish`, this was causing `npm ci` for installing dependencies to fail in GitHub actions and cause our integrations to stop working. This PR does a few things: - Fixes the offending deployment - Adds a new workflow that is executed in CI on PRs, to prevent mistakes from happening in the future - Changes `prepublish` to `prepare` as the former was deprecated in favour of the latter ([source](https://docs.npmjs.com/cli/v8/using-npm/scripts#prepare-and-prepublish)) This should make the `prepare_transaction` scripts to start working again.
nlordell
commented
Jul 28, 2025
|
|
||
| - run: | | ||
| npm ci | ||
| npm run build |
There was a problem hiding this comment.
While not technically needed (since npm ci will run the build step), I decided to leave it in because:
- It runs super quickly anyway
- It makes it so CI does not depend on
preparescript doing a build. This allows us to changepreparetoprepublishOnlyfor example without affecting the integrity of the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things happened at the same time:
prettier -c .was added to the build stepSince we
buildonprepublish, this was causingnpm cifor installing dependencies to fail in GitHub actions and cause our integrations to stop working.This PR does a few things:
prepublishtoprepareas the former was deprecated in favour of the latter (source)This should make the
prepare_transactionscripts to start working again.