Skip to content

Commit 093542a

Browse files
committed
Don't create a new EthereumClient in every about query
- Session was not closed
1 parent 6056eff commit 093542a

File tree

1 file changed

+5
-4
lines changed
  • safe_transaction_service/history

1 file changed

+5
-4
lines changed

safe_transaction_service/history/views.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,12 @@ def get(self, request, format=None):
150150
"""
151151
Get information about the Ethereum Tracing RPC node used by the service (if any configured)
152152
"""
153-
if not settings.ETHEREUM_TRACING_NODE_URL:
154-
return Response(status=status.HTTP_404_NOT_FOUND)
153+
safe_service = SafeServiceProvider()
154+
ethereum_tracing_client = safe_service.ethereum_tracing_client
155+
if ethereum_tracing_client:
156+
return Response(self._get_info(ethereum_tracing_client))
155157
else:
156-
ethereum_client = EthereumClient(settings.ETHEREUM_TRACING_NODE_URL)
157-
return Response(self._get_info(ethereum_client))
158+
return Response(status=status.HTTP_404_NOT_FOUND)
158159

159160

160161
@extend_schema(responses={200: serializers.IndexingStatusSerializer})

0 commit comments

Comments
 (0)