Skip to content

Test contract signatures for 1.3.0 and 1.4.1 Safes #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uxio0 merged 1 commit into from
Jun 6, 2025
+13 −3
Merged

Test contract signatures for 1.3.0 and 1.4.1 Safes #2536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions safe_transaction_service/safe_messages/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,10 @@ def test_safe_messages_create_view(self, get_owners_mock: MagicMock):
},
)

def test_safe_messages_create_using_1271_signature_view(self):
def _test_safe_messages_create_using_1271_signature_view(self, safe_deployment_fn):
account = Account.create()
safe_owner = self.deploy_test_safe(owners=[account.address])
safe = self.deploy_test_safe(owners=[safe_owner.address])
safe_owner = safe_deployment_fn(owners=[account.address])
safe = safe_deployment_fn(owners=[safe_owner.address])

safe_address = safe.address
message = get_eip712_payload_mock()
Expand Down Expand Up @@ -317,6 +317,16 @@ def test_safe_messages_create_using_1271_signature_view(self):
self.assertEqual(SafeMessage.objects.count(), 1)
self.assertEqual(SafeMessageConfirmation.objects.count(), 1)

def test_safe_messages_create_using_1271_signature_v1_3_0_view(self):
return self._test_safe_messages_create_using_1271_signature_view(
self.deploy_test_safe_v1_3_0
)

def test_safe_messages_create_using_1271_signature_v1_4_1_view(self):
return self._test_safe_messages_create_using_1271_signature_view(
self.deploy_test_safe_v1_4_1
)

@mock.patch(
"safe_transaction_service.safe_messages.serializers.get_safe_owners",
return_value=[],
Expand Down