Optimize tx processing #2563
Merged
Optimize tx processing #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
force-pushed
the
optimize-tx-processing-all-safes
branch
3 times, most recently
from
61239ac to
df9f8d2
Compare
falvaradorodriguez
previously approved these changes
Jul 3, 2025
falvaradorodriguez
approved these changes
Jul 7, 2025
| for internal_tx_decoded in internal_txs_decoded: | ||
| for internal_tx_decoded in internal_txs_decoded_list: | ||
| contract_address = internal_tx_decoded.internal_tx._from | ||
| contract_addresses.add(contract_address) |
Contributor
There was a problem hiding this comment.
This add is redundant now?
Process every Safe together: - Less database sessions/transactions - Less database queries to get internal txs for every Safe
Uxio0
force-pushed
the
optimize-tx-processing-all-safes
branch
from
df9f8d2 to
4d74472
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process every Safe together: