Skip to content

Comments

fix: fix missing native transfers in all-transactions for multiSend o…#2773

Open
crlosif wants to merge 2 commits intosafe-global:mainfrom
crlosif:main
Open

fix: fix missing native transfers in all-transactions for multiSend o…#2773
crlosif wants to merge 2 commits intosafe-global:mainfrom
crlosif:main

Conversation

@crlosif
Copy link

@crlosif crlosif commented Feb 5, 2026

ref #2764
…n chains without tracing

Make sure these boxes are checked! 📦✅

  • You ran ./run_tests.sh
  • You ran pre-commit run -a
  • If you want to add your network to setup_service.py, provide a link to your
    safe-deployments PR and check network name
    exists in safe-eth-py

What was wrong? 👾

Closes #

How was it fixed? 🎯

  • Decode multiSend batch data when a multisig tx has no indexed native transfers and add synthetic ETHER_TRANSFER entries from valueDecoded (operation=CALL, value>0).
  • Enrich transfer_dict only when ether_count is 0 to avoid duplicating transfers on chains that do provide tracing (e.g. Sepolia).
  • Add _get_native_transfers_from_multisend and _enrich_transfers_from_multisend_decoded in TransactionService.
  • Add test_multisend_native_transfers_enriched_when_no_traces.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@crlosif
Copy link
Author

crlosif commented Feb 5, 2026

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant