Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(safenet): Show Safenet tx status, spends and debits #4874

Draft
wants to merge 7 commits into
base: safenet
Choose a base branch
from

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Feb 4, 2025

What it solves

Partially solves https://github.com/safe-global/safenet/issues/293

Todos

  • Link to settlements
  • Link from settlements to tx
  • Show pending status whilst the transaction is not available / found on processor API

How this PR fixes it

  • Adds new section for Safenet transaction details
  • For now lists all spends, debits and derives a Safenet transaction status

How to test it

  • Create or open a Safe account that has Safenet enabled
  • Create transaction
  • Observe the status being tracked

Screenshots

Screenshot 2025-02-04 at 17 31 01
Screenshot 2025-02-04 at 17 31 19
Screenshot 2025-02-04 at 17 33 34

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
74.02% (-0.16% 🔻)
14944/20190
🔴 Branches
51.53% (-0.37% 🔻)
3577/6942
🔴 Functions
56.6% (-0.38% 🔻)
2104/3717
🟡 Lines
75.56% (-0.16% 🔻)
13569/17958
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
75% 100% 100% 100%
🔴
... / SafenetTransactionDetails.tsx
41.98% 5.71% 5.26% 44%
🟢
... / index.tsx
66.67% 0% 0% 80%
🔴
... / SafenetSettlementLink.tsx
43.75% 0% 0% 46.67%
🟡
... / index.tsx
61.9% 0% 0% 65%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / safenet.ts
32.14% (-5.36% 🔻)
100%
7.14% (-1.19% 🔻)
30.77% (-4.23% 🔻)

Test suite run success

1794 tests passing in 242 suites.

Report generated by 🧪jest coverage report action from 1dd15a2

Copy link

github-actions bot commented Feb 4, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.05 MB (🟡 +61.79 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/settings/safenet 1.97 KB 1.05 MB

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1.05 MB
/address-book 23.21 KB (🟡 +142 B) 1.07 MB
/apps 35.84 KB (🟡 +2.11 KB) 1.08 MB
/apps/custom 33.9 KB (🟡 +2.12 KB) 1.08 MB
/apps/open 55.74 KB (🟡 +2.13 KB) 1.1 MB
/balances 29.94 KB (🟡 +240 B) 1.08 MB
/balances/nfts 9.55 KB (🟡 +10 B) 1.06 MB
/bridge 2.56 KB (🟡 +2 B) 1.05 MB
/cookie 8.77 KB (🟡 +1 B) 1.06 MB
/home 61.56 KB (🟡 +2.3 KB) 1.11 MB
/new-safe/advanced-create 26.38 KB (🟢 -70 B) 1.07 MB
/new-safe/create 25.52 KB (🟢 -71 B) 1.07 MB
/privacy 14.57 KB (🟡 +2 B) 1.06 MB
/settings/appearance 2.28 KB (🟡 +38 B) 1.05 MB
/settings/cookies 1.92 KB (🟡 +46 B) 1.05 MB
/settings/data 1.83 KB (🟡 +43 B) 1.05 MB
/settings/environment-variables 3.32 KB (🟡 +44 B) 1.05 MB
/settings/modules 4.14 KB (🟡 +91 B) 1.05 MB
/settings/notifications 6.37 KB (🟢 -14.95 KB) 1.06 MB
/settings/safe-apps 20.44 KB (🟡 +2.17 KB) 1.07 MB
/settings/security 2.37 KB (🟡 +39 B) 1.05 MB
/settings/setup 30.87 KB (🟡 +138 B) 1.08 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.06 MB
/swap 761 B (🟡 +1 B) 1.05 MB
/terms 12.93 KB (🟡 +1 B) 1.06 MB
/transactions 99.6 KB (🟡 +3.03 KB) 1.15 MB
/transactions/history 99.57 KB (🟡 +3.03 KB) 1.15 MB
/transactions/messages 60.39 KB (🟡 +2.09 KB) 1.11 MB
/transactions/msg 56.65 KB (🟡 +2.1 KB) 1.1 MB
/transactions/queue 49.5 KB (🟡 +2.1 KB) 1.1 MB
/transactions/tx 48.86 KB (🟡 +2.1 KB) 1.1 MB
/welcome/accounts 409 B (🟡 +2 B) 1.05 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant