Fix(Tx history filter): incoming amount with decimals #4947
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
📦 Next.js Bundle Analysis for @safe-global/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.06 MB (🟡 +75.75 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirty-five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
509 B (🟢 -1 B) |
1.06 MB |
/address-book |
23.21 KB (🟡 +140 B) |
1.09 MB |
/apps |
35.75 KB (🟡 +2.03 KB) |
1.1 MB |
/apps/custom |
33.82 KB (🟡 +2.03 KB) |
1.1 MB |
/apps/open |
55.36 KB (🟡 +1.75 KB) |
1.12 MB |
/balances |
29.57 KB (🟢 -144 B) |
1.09 MB |
/balances/nfts |
9.31 KB (🟢 -235 B) |
1.07 MB |
/bridge |
2.55 KB (🟢 -4 B) |
1.07 MB |
/cookie |
8.77 KB (🟡 +1 B) |
1.07 MB |
/home |
61.31 KB (🟡 +2.05 KB) |
1.12 MB |
/licenses |
2.46 KB (🟢 -1 B) |
1.07 MB |
/new-safe/advanced-create |
26.38 KB (🟢 -77 B) |
1.09 MB |
/new-safe/create |
25.52 KB (🟢 -70 B) |
1.09 MB |
/privacy |
14.57 KB (🟡 +2 B) |
1.08 MB |
/settings/appearance |
2.25 KB (🟡 +1 B) |
1.07 MB |
/settings/cookies |
1.87 KB (🟡 +1 B) |
1.06 MB |
/settings/data |
1.79 KB (🟢 -1 B) |
1.06 MB |
/settings/environment-variables |
3.28 KB (🟡 +1 B) |
1.07 MB |
/settings/modules |
2.88 KB (🟢 -1.18 KB) |
1.07 MB |
/settings/notifications |
7.49 KB (🟢 -13.82 KB) |
1.07 MB |
/settings/safe-apps |
20.15 KB (🟡 +1.87 KB) |
1.08 MB |
/settings/security |
2.34 KB (🟡 +2 B) |
1.07 MB |
/settings/setup |
30.97 KB (🟡 +246 B) |
1.09 MB |
/share/safe-app |
7.55 KB (🟢 -9 B) |
1.07 MB |
/stake |
617 B (🟢 -2 B) |
1.06 MB |
/swap |
763 B (🟡 +3 B) |
1.06 MB |
/terms |
12.93 KB (🟡 +1 B) |
1.08 MB |
/transactions |
99.49 KB (🟡 +2.91 KB) |
1.16 MB |
/transactions/history |
99.45 KB (🟡 +2.91 KB) |
1.16 MB |
/transactions/messages |
60.25 KB (🟡 +1.95 KB) |
1.12 MB |
/transactions/msg |
56.5 KB (🟡 +1.95 KB) |
1.12 MB |
/transactions/queue |
49.36 KB (🟡 +1.96 KB) |
1.11 MB |
/transactions/tx |
48.72 KB (🟡 +1.96 KB) |
1.11 MB |
/welcome |
6.93 KB (🟢 -2 B) |
1.07 MB |
/welcome/accounts |
408 B (🟡 +1 B) |
1.06 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 77.57% (-0.33% 🔻) |
14078/18149 |
| 🔴 | Branches | 57.1% (-0.58% 🔻) |
3561/6236 |
| 🟡 | Functions | 62.77% (-0.24% 🔻) |
2118/3374 |
| 🟡 | Lines | 79.02% (-0.33% 🔻) |
12701/16073 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / transaction-guards.ts |
70.79% (-3% 🔻) |
42.06% (-2.8% 🔻) |
69.44% (-2.78% 🔻) |
71.28% (-2.56% 🔻) |
| 🟡 | ... / index.tsx |
71.88% (-15.63% 🔻) |
13.33% (-40% 🔻) |
66.67% (-33.33% 🔻) |
72.41% (-13.79% 🔻) |
| 🔴 | ... / index.tsx |
45.16% (-32.26% 🔻) |
0% (-11.76% 🔻) |
0% (-20% 🔻) |
48.28% (-31.03% 🔻) |
| 🟢 | ... / tx-history-filter.ts |
100% | 88.57% (-1.75% 🔻) |
100% | 100% |
| 🟡 | ... / index.tsx |
78.13% (-21.88% 🔻) |
8.33% (-29.17% 🔻) |
100% | 77.42% (-22.58% 🔻) |
| 🟡 | ... / index.tsx |
69.64% (-23.21% 🔻) |
9.52% (-38.1% 🔻) |
66.67% (-33.33% 🔻) |
70.37% (-24.07% 🔻) |
| 🔴 | ... / index.tsx |
40% (-24% 🔻) |
4.88% (-9.76% 🔻) |
9.09% (-18.18% 🔻) |
41.3% (-23.91% 🔻) |
| 🟢 | ... / TxShareButton.tsx |
80% (-20% 🔻) |
100% | 0% (-100% 🔻) |
80% (-20% 🔻) |
| 🟡 | ... / index.tsx |
64.29% (-35.71% 🔻) |
0% | 0% (-100% 🔻) |
69.23% (-30.77% 🔻) |
| 🟡 | ... / index.tsx |
72.73% (-9.09% 🔻) |
100% | 0% | 77.78% |
Test suite run success
1828 tests passing in 249 suites.
Report generated by 🧪jest coverage report action from c44fa97
| @@ -189,7 +191,9 @@ const TxFilterForm = ({ toggleFilter }: { toggleFilter: () => void }): ReactElem | |||
| className={inputCss.input} | |||
| label={ | |||
| fieldState.error?.message || | |||
| `Amount${isMultisigFilter && chain ? ` (only ${chain.nativeCurrency.symbol})` : ''}` | |||
| (isIncomingFilter | |||
| ? 'Amount (with decimals)' | |||
There was a problem hiding this comment.
Not sure if "with decimals" is clear enough. Maybe it should say "with zeroes"?
There was a problem hiding this comment.
I think "with zeros" is clearer because "decimals" suggest a float. We also could add a tooltip explaining it's the "base amount".
| const NATIVE_DECIMALS = 18 | ||
| const parseNativeValue = (value: string) => safeParseUnits(value, NATIVE_DECIMALS)?.toString() | ||
| const formatNativeValue = (value: string) => safeFormatUnits(value, NATIVE_DECIMALS) |
There was a problem hiding this comment.
I see that this was 18 before but the native currency decimals can be set on the Config Service. Do you think it's worth reading the config instead?
There was a problem hiding this comment.
Yes, that would be more correct, although a quick google/chatgpt indicates they try to stick to 18. I'll pass decimals from chain info anyway.
| @@ -189,7 +191,9 @@ const TxFilterForm = ({ toggleFilter }: { toggleFilter: () => void }): ReactElem | |||
| className={inputCss.input} | |||
| label={ | |||
| fieldState.error?.message || | |||
| `Amount${isMultisigFilter && chain ? ` (only ${chain.nativeCurrency.symbol})` : ''}` | |||
| (isIncomingFilter | |||
| ? 'Amount (with decimals)' | |||
There was a problem hiding this comment.
I think "with zeros" is clearer because "decimals" suggest a float. We also could add a tooltip explaining it's the "base amount".
What it solves
Resolves #4942
How this PR fixes it
For the incoming filter, the amount now must be specified in a decimal format (with zeroes) and not assume the default 18 decimals. This allows filtering by amounts for various tokens w/o specifying a token address.
How to test it