Skip to content

fix: OpenClaw integration - #31

Open
abhisek wants to merge 3 commits into
mainfrom
fix/enable-openclaw-agent-adapter
Open

fix: OpenClaw integration#31
abhisek wants to merge 3 commits into
mainfrom
fix/enable-openclaw-agent-adapter

Conversation

@abhisek

@abhisek abhisek commented Mar 23, 2026

Copy link
Copy Markdown
Member

@safedep

safedep Bot commented Mar 23, 2026

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@codecov-commenter

codecov-commenter commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.80%. Comparing base (d4dda92) to head (38286f2).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
agent/openclaw/hooks.go 0.00% 20 Missing ⚠️
cli/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   10.80%   10.80%   -0.01%     
==========================================
  Files         194      194              
  Lines       22813    22836      +23     
==========================================
+ Hits         2466     2468       +2     
- Misses      20035    20056      +21     
  Partials      312      312              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 5 additional findings in Devin Review.

Open in Devin Review

Comment thread agent/openclaw/hooks.go

@devin-ai-integration devin-ai-integration Bot Mar 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 "Already installed" check returns early without writing new required manifest and package.json files

When InstallHooks detects that the plugin file (index.ts) already exists and contains "invokeGryph", it returns early at line 80 with a success warning, skipping the manifest and package.json writes at lines 127-137. This means that users upgrading from a previous gryph version (which didn't deploy these files) will get a misleading "already installed" success, while GetHookStatus (agent/openclaw/hooks.go:234-244) will report the installation as invalid due to the missing openclaw.plugin.json and package.json. The only workaround is gryph install --force, but users won't know this unless they run gryph status.

Suggested fix approach

The "already installed" check should also verify that the manifest and package.json exist. If they are missing, the install should proceed to write them (or at least the missing files) rather than returning early.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread agent/openclaw/hooks.go

@devin-ai-integration devin-ai-integration Bot Mar 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 UninstallHooks with RestoreBackup leaves manifest file behind

When UninstallHooks is called with RestoreBackup, it only restores the plugin file (index.ts) and returns early at line 160 without removing the gryph-specific manifest file (openclaw.plugin.json). This leaves a gryph artifact in the plugin directory even though the intent of restore-uninstall is to return to the pre-gryph state. The manifest was never backed up during install (only the plugin file was), so there's nothing to restore for it — it should simply be removed.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants