Ci/v5 trigger and matrix#615
Open
mtt-ai wants to merge 2 commits intosafishamsi:v5from
Open
Conversation
Defines a `test` optional-dependencies group so CI can install dev tooling via `pip install -e ".[all,test]"` instead of an ad-hoc `pip install pytest` sidecar. Kept out of `[all]` deliberately — `[all]` is runtime extras only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
CI on
v5(the default branch) currently does not run —.github/workflows/ci.ymllists["v1", "v2", "v3", "v4", "main"]in itspush/pull_requesttriggers but omitsv5. Every commit and PR to the active development branch ships without test coverage.Changes
.github/workflows/ci.ymlv5to bothpushandpull_requesttriggers — main fix.3.10/3.11/3.12/3.13to matchrequires-python = ">=3.10". Python 3.13 silently skips graspologic via its existingpython_version < '3.13'marker.[all,test]instead of[mcp,pdf,watch]+ sidecarpip install pytest. Tests coveringtranscribe(video),cluster(leiden),serve(mcp),export(svg) now have their dependencies available.cache: 'pip'+cache-dependency-path: pyproject.toml).concurrency:block (cancel-in-progress: trueon same ref).permissions: { contents: read }for least-privilege.fail-fast: falseso a single Python-version regression doesn't mask the others.workflow_dispatch:for manual reruns.pyproject.tomlAdds
test = ["pytest>=7", "pytest-cov"]optional-dependencies group. Kept out of[all]deliberately —[all]is runtime extras only.Verification
v5and confirm the run shows up ingh run list -R safishamsi/graphify -b v5.Out of scope
Multi-OS matrix, coverage upload, SHA-pinning actions, pruning v1–v4 from triggers.