Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39933.
The issue was that, starting from a finite field
Kwithout a_prefixattribute, it was impossible to create a p-adic ring whose reduction wasK.I had two reports from other users stating that it was an issue for them, on my side it was a problem in the Witt vector packages: I added the relevant doctest there.
It was necessary to do a change in the
create_key_and_extra_argsmethod of finite fields. I believe it should not be too controversial. Namely, thecheck_irreducibleandcheck_primearguments are now extra arguments, and not part of the key. This move is necessary to test that two finite fields created with and without these options are considered equal.📝 Checklist