Skip to content

Conversation

@r-mb
Copy link
Contributor

@r-mb r-mb commented Jan 27, 2026

Fixes #39933.
The issue was that, starting from a finite field K without a _prefix attribute, it was impossible to create a p-adic ring whose reduction was K.
I had two reports from other users stating that it was an issue for them, on my side it was a problem in the Witt vector packages: I added the relevant doctest there.

It was necessary to do a change in the create_key_and_extra_args method of finite fields. I believe it should not be too controversial. Namely, the check_irreducible and check_prime arguments are now extra arguments, and not part of the key. This move is necessary to test that two finite fields created with and without these options are considered equal.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@r-mb r-mb added c: padics c: finite rings sd130 tickets of Sage Days 130 Le Teich labels Jan 27, 2026
@r-mb r-mb requested a review from roed314 January 27, 2026 22:06
@r-mb
Copy link
Contributor Author

r-mb commented Jan 27, 2026

@roed314 I am pinging you because I remember you telling me you had a colleague affected by this bug. If by any chance she would be able to check that this patch fixes her issues, it would be super wonderful.

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Documentation preview for this PR (built with commit 3db25b6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_prefix, FiniteField and p-adics

1 participant