sage/graphs/graph_database.py: compute database path only on init #41560
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we compute the graphs database location when this module is imported, but the database is not guaranteed to be present. Indeed, the sage.features.databases.DatabaseGraphs feature exists to detect it. I don't know whether or not this module works (passes tests) without the database, but now at least it is importable. This allows one to run "pytest --doctest --collect-only" without errors on a system where the database is not installed.
|
Documentation preview for this PR (built with commit 6681544; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we compute the graphs database location when this module is imported, but the database is not guaranteed to be present. Indeed, the
sage.features.databases.DatabaseGraphsfeature exists to detect it.I don't know whether or not this module works (passes tests) without the database, but now at least it is importable. This allows one to run
pytest --doctest --collect-onlywithout errors on a system where the database is not installed.