Set ruff format quote-style to preserve#42145
Merged
Merged
Conversation
kryzar
approved these changes
May 8, 2026
kryzar
left a comment
Contributor
There was a problem hiding this comment.
I think this is a good addition. If we fix a convention, we can change that file. I approve the PR.
|
Documentation preview for this PR (built with commit 404c224; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have not adopted a strict rule throughout the project on using
'versus"for quotes. This PR changes our ruff configuration to leave quotes alone, so that developers can useruff formatwithout creating large diffs that mostly just change'to". If we ever decide to enforce either single or double quotes, we can just change this config option then.Hopefully this makes it easier to use
ruff formatmore often when developing Sage without cluttering diffs.📝 Checklist
⌛ Dependencies