Skip to content

Set ruff format quote-style to preserve#42145

Merged
vbraun merged 1 commit into
sagemath:developfrom
vincentmacri:ruff-strings
May 18, 2026
Merged

Set ruff format quote-style to preserve#42145
vbraun merged 1 commit into
sagemath:developfrom
vincentmacri:ruff-strings

Conversation

@vincentmacri

Copy link
Copy Markdown
Member

We have not adopted a strict rule throughout the project on using ' versus " for quotes. This PR changes our ruff configuration to leave quotes alone, so that developers can use ruff format without creating large diffs that mostly just change ' to ". If we ever decide to enforce either single or double quotes, we can just change this config option then.

Hopefully this makes it easier to use ruff format more often when developing Sage without cluttering diffs.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kryzar kryzar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition. If we fix a convention, we can change that file. I approve the PR.

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 404c224; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun vbraun merged commit a0b03ea into sagemath:develop May 18, 2026
25 checks passed
@vincentmacri vincentmacri deleted the ruff-strings branch May 29, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants