Support libgap conversion for general and relative number fields#42435
Open
cxzhong wants to merge 1 commit into
Open
Support libgap conversion for general and relative number fields#42435cxzhong wants to merge 1 commit into
cxzhong wants to merge 1 commit into
Conversation
Extend libgap(...) conversion beyond cyclotomic fields so matrix groups (and Coxeter groups) over number fields use the GAP backend. - NumberFieldElement._libgap_ converts absolute and relative fields via the GAP algebraic-extension tower. Relative elements use the relative power-basis coordinates (self.list()), which match GAP's generator even when it is not an absolute primitive element of the field. - NumberField_generic._libgap_ builds relative fields as towers of GAP algebraic extensions, and is now cached. - The reverse conversion is centralized in _convert_from_gap_string, which strips GAP's '!' constant markers and interprets cyclotomic 'E(n)' in the field tower rather than the universal cyclotomic field.
|
Documentation preview for this PR (built with commit f79d402; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Extend
libgap(...)conversion beyond cyclotomic fields so that matrixgroups (and Coxeter groups) over number fields can use the GAP backend.
NumberFieldElement._libgap_converts both absolute and relative fieldsvia the GAP algebraic-extension tower. Relative elements use the relative
power-basis coordinates (
self.list()), which match GAP's generator evenwhen it is not an absolute primitive element of the field.
NumberField_generic._libgap_builds relative fields as towers of GAPalgebraic extensions, and is now cached.
_convert_from_gap_string, whichstrips GAP's
!constant markers and interprets cyclotomicE(n)in thefield tower rather than in the universal cyclotomic field.
This is split out from #42383 (CoxeterGroup default base ring), which depends
on this conversion support but is reviewed separately.
📝 Checklist