enable the check keyword argument#42446
Open
mantepse wants to merge 2 commits into
Open
Conversation
|
Documentation preview for this PR (built with commit 30476c4; changes) is ready! 🎉 |
2 tasks
anneschilling
approved these changes
Jun 29, 2026
anneschilling
left a comment
anneschilling
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me as long as all doc tests pass. The checks are indeed not necessary for RSK and slow things down.
Contributor
Author
|
The bot is green. |
Contributor
Great, I set a positive review! |
Collaborator
|
Strictly speaking, this is actually not unnecessary because a user could pass something through RSK that is not actually a SSYT (such as negative entries). Of course, it will still be semistandard in that (totally ordered) alphabet. Anyways, garbage-in-garbage-out is a good mantra, especially in terms of speed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We allow creating various tableaux without checking, which may be costly and unnecessary. In particular, we turn off checking in
rsk.py, because the algorithms guarantee that the output satisfies the conditions.See also #41503.