Add cache keys for combinations#42458
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
|
Documentation preview for this PR (built with commit a97f106; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
_cache_key()to the finiteCombinationsparents so they can be used by cached constructions such ascartesian_productThe issue was that
Combinations(...)parents define equality but are not hashable, and they also did not provide_cache_key(). That madecartesian_product([Combinations([1,2,3], 2), Combinations([1,2,3], 2)])fail while building the cached Cartesian product parentThe change keeps the parents unhashable and only adds cache keys for the existing cache machinery. The key includes the concrete class, the multiset data,
kwhen present, and theas_tuplesoutput modeFixes #39004
Related to #19986
Checks:
./sage -t --long src/sage/combinat/combination.py./sage -tox -e relint -- src/sage/combinat/combination.py./sage -tox -e rst -- src/sage/combinat/combination.pyas_tuplescombinations insidecartesian_product📝 Checklist
⌛ Dependencies
None