unbreak kenzo in sage-distro#42461
Open
dimpase wants to merge 1 commit into
Open
Conversation
Member
Author
|
renaming prefix->kenzo_prefix is purely cosmetic, to reduce the cognitive load... |
Contributor
|
config.py is not supposed to be pulling stuff from the environment, it's only for build configuration... Does spkg-configure.m4 even make substitutions into config.py.in? In #42432 the answer was no. (The kenzo SPKG can be built long after sagelib and config.py are installed?) In the long term we should have |
Contributor
|
How about:
Hard-coding the sage-distro path in sagelib is dumb, but might get this working without wasting a lot of our time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix the problem of detecting/using kenzo in sage-distro,
see https://groups.google.com/g/sage-devel/c/SFGi4E_cIH4/m/K0PC7W9BAAAJ
and #42459
📝 Checklist
⌛ Dependencies